Create a list of local speakers#1993
Merged
ZYSzys merged 4 commits intonodejs:masterfrom Jan 23, 2019
Merged
Conversation
Create a list of local speakers for local meetups to connect with! :)
Contributor
Author
|
@obensource @dshaw @bnb @joesepi @mhdawson hayyyy! :) inspired after the user feedback meeting to create this too. |
Contributor
Author
|
@chowdhurian here you can poke at this one too :) |
keywordnew
approved these changes
Jan 18, 2019
Contributor
keywordnew
left a comment
keywordnew
left a comment
There was a problem hiding this comment.
LGTM! Solid idea for a resource 🎉
Contributor
Author
|
@chowdhurian gotta get it merged so you can add yourself! |
keywordnew
reviewed
Jan 18, 2019
Co-Authored-By: ladyleet <tracy@thisdot.co>
willin
approved these changes
Jan 21, 2019
Contributor
willin
left a comment
willin
left a comment
There was a problem hiding this comment.
LGTM.
btw, i wonder why only Canada using emoji
ZYSzys
reviewed
Jan 22, 2019
SofiEstevez
approved these changes
Jan 22, 2019
SofiEstevez
approved these changes
Jan 22, 2019
SofiEstevez
approved these changes
Jan 22, 2019
Contributor
|
@mhdawson I think we are ready to merge right? |
Co-Authored-By: ladyleet <tracy@thisdot.co>
Contributor
Author
|
@chowdhurian so after we created these two we need to submit PRs to update the actual site so they show up as resources no? |
keywordnew
added a commit
to keywordnew/nodejs.org
that referenced
this pull request
Jan 23, 2019
Dependent on nodejs#1993.
Contributor
ZYSzys
approved these changes
Jan 23, 2019
Member
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a list of local speakers for local meetups to connect with! :)