Skip to content

quic: fixup quic stream variable chunk len#63230

Closed
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/quic-issue-63216
Closed

quic: fixup quic stream variable chunk len#63230
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/quic-issue-63216

Conversation

@jasnell
Copy link
Copy Markdown
Member

@jasnell jasnell commented May 10, 2026

Fixes: #63216

@jasnell jasnell added the quic Issues and PRs related to the QUIC implementation / HTTP/3. label May 10, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 10, 2026
@jasnell jasnell changed the title quic: fiup quic stream variable chunk len quic: fixup quic stream variable chunk len May 10, 2026
@jasnell jasnell force-pushed the jasnell/quic-issue-63216 branch from a560a10 to 4ade24f Compare May 10, 2026 20:38
@nodejs-github-bot

This comment was marked as outdated.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.03%. Comparing base (facd71e) to head (eafeb01).
⚠️ Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63230      +/-   ##
==========================================
- Coverage   90.04%   90.03%   -0.01%     
==========================================
  Files         713      714       +1     
  Lines      224950   225243     +293     
  Branches    42530    42572      +42     
==========================================
+ Hits       202548   202802     +254     
- Misses      14188    14221      +33     
- Partials     8214     8220       +6     
Files with missing lines Coverage Δ
lib/internal/quic/quic.js 100.00% <100.00%> (ø)

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@jasnell jasnell requested review from Qard and pimterry May 11, 2026 02:26
Comment thread lib/internal/quic/quic.js Outdated
Comment thread src/quic/streams.cc Outdated
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell jasnell force-pushed the jasnell/quic-issue-63216 branch from 4ade24f to eafeb01 Compare May 13, 2026 03:15
@jasnell jasnell requested a review from pimterry May 13, 2026 03:22
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 14, 2026

@jasnell jasnell requested a review from mcollina May 14, 2026 13:38
@jasnell jasnell added the experimental Issues and PRs related to experimental features. label May 14, 2026
Copy link
Copy Markdown
Member

@pimterry pimterry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach looks much better, very nice 👍

I take it this means we're going towards option 1 from my previous backpressure comment? I.e. stream/iter writables are required to always accept one pending write, even in strict mode, and to deal with any internal byte-based limits & backpressure via internal buffering only. Doesn't need to happen immediately, but once we're settled there it'd be good to write that into the stream/iter writer docs explicitly.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnell
Copy link
Copy Markdown
Member Author

jasnell commented May 15, 2026

@pimterry ... I think the backpressure strategy for both stream/iter and this as an application of that api still needs a thorough review, which I plan to get to soon.

jasnell added a commit that referenced this pull request May 15, 2026
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #63230
Fixes: #63216
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell
Copy link
Copy Markdown
Member Author

jasnell commented May 15, 2026

Landed in e9c49ea

@jasnell jasnell closed this May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quic: stream stalls with chunks of varying sizes

4 participants