quic: fixup quic stream variable chunk len#63230
Conversation
|
Review requested:
|
a560a10 to
4ade24f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63230 +/- ##
==========================================
- Coverage 90.04% 90.03% -0.01%
==========================================
Files 713 714 +1
Lines 224950 225243 +293
Branches 42530 42572 +42
==========================================
+ Hits 202548 202802 +254
- Misses 14188 14221 +33
- Partials 8214 8220 +6
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: James M Snell <jasnell@gmail.com>
4ade24f to
eafeb01
Compare
This comment was marked as outdated.
This comment was marked as outdated.
pimterry
left a comment
There was a problem hiding this comment.
This approach looks much better, very nice 👍
I take it this means we're going towards option 1 from my previous backpressure comment? I.e. stream/iter writables are required to always accept one pending write, even in strict mode, and to deal with any internal byte-based limits & backpressure via internal buffering only. Doesn't need to happen immediately, but once we're settled there it'd be good to write that into the stream/iter writer docs explicitly.
|
@pimterry ... I think the backpressure strategy for both stream/iter and this as an application of that api still needs a thorough review, which I plan to get to soon. |
|
Landed in e9c49ea |
Fixes: #63216