fs: improve cpSync no-filter copyDir performance#58461
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jun 7, 2025
Merged
fs: improve cpSync no-filter copyDir performance#58461nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move the logic in
cpSyncthat copies a directory from src to dest from JavaScript to C++ increasing its performanceNote: this improvement is not applied if the filter option is
provided, such optimization will be looked into separately
Example of perf improvement