Skip to content

meta: edit collaborator nomination process#57483

Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom
aduh95:nomination-process-semver-patch
Mar 19, 2025
Merged

meta: edit collaborator nomination process#57483
nodejs-github-bot merged 2 commits intonodejs:mainfrom
aduh95:nomination-process-semver-patch

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 15, 2025

This PR tries to address a few concerns raised in nodejs/TSC#1702 that seems small enough that it may get consensus already. This PR:

  • recommend more strongly a private discussion prior to a public one.
  • remove requirement for at-mentioning the collaborators team.
  • add requirement for the nominee to publicly accept the nomination.
  • move recommendation for heads up comment from "How to review
    nominations" section to "Nominating new Collaborator" section.

This shouldn't block us from discussing making deeper changes to the nomination process, but it should already improve the status quo IMO.

/cc @nodejs/collaborators

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.