Skip to content

assert: make myers_diff function more performant#56303

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
puskin:assert-make-myers-more-performant
Jan 11, 2025
Merged

assert: make myers_diff function more performant#56303
nodejs-github-bot merged 1 commit intonodejs:mainfrom
puskin:assert-make-myers-more-performant

Conversation

@puskin
Copy link
Contributor

@puskin puskin commented Dec 18, 2024

now that Myers diff has landed, I took the liberty to review the code I wrote to look for improvements that would squeeze some more performance out of the comparison mechanism

  • simplified some logic
  • reviewed loops and introduced more breaking points to make them run for less cycles
  • reduced memory allocation using Int32Array

Refs: #54862

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants