module: support eval with ts syntax detection#56285
Merged
nodejs-github-bot merged 3 commits intonodejs:mainfrom Dec 24, 2024
Merged
module: support eval with ts syntax detection#56285nodejs-github-bot merged 3 commits intonodejs:mainfrom
nodejs-github-bot merged 3 commits intonodejs:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/typescript#17
Previous attempt: #56273
What is the problem?
Before this PR when
--experimental-strip-typeswas enabled,--evalwould always parse the input as typescript.If unflagged, the typescript parser would throw different errors on invalid syntax so unflagging would become a breaking change.
With this PR when running
--evaland--experimental-strip-typesis enabled, if parsing the code fails we try again with typescript parser.If it fails again we throw the original error, adding the typescript parser message.
In this way the error is the original error and it's not a breaking change.
Example:
This PR also add two new
--input-type:module-typescriptcommonjs-typescriptSo that if the syntax is known we can reduce the overhead of multiple parsing.
If the
-typescriptinput is passed we can throwERR_INVALID_TYPESCRIPT_SYNTAXsafely