sqlite: add support for SQLite Session Extension#54181
Merged
nodejs-github-bot merged 31 commits intonodejs:mainfrom Nov 18, 2024
Merged
sqlite: add support for SQLite Session Extension#54181nodejs-github-bot merged 31 commits intonodejs:mainfrom
nodejs-github-bot merged 31 commits intonodejs:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were talking about adding support for the Session Extension of SQLite in #53752. This is not a run-time extension but rather a feature built in to the SQLite amalgamation. It can be enabled with a compile flag and is enabled by default on some platforms.
I have never contributed to Node.js before so I will probably need some help to bring this to a conclusion.
TODO:
Throw with specific (documented) exception in case of conflict when applying changesetsince SQLite doesn't consider this to be an error I returnfalsewhen applying the changeset is aborted due to a conflictExample usage: