Skip to content

Fix duplicated test descriptions#54140

Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom
unseen1980:duplicated-test-names
Sep 27, 2024
Merged

Fix duplicated test descriptions#54140
nodejs-github-bot merged 2 commits intonodejs:mainfrom
unseen1980:duplicated-test-names

Conversation

@unseen1980
Copy link
Contributor

@unseen1980 unseen1980 commented Jul 31, 2024

Some unit tests had duplicate names. Please review these small changes.

Thanks
Christos

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@mhdawson mhdawson mhdawson approved these changes

@aduh95 aduh95 aduh95 approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@unseen1980 @nodejs-github-bot @avivkeller @marco-ippolito @aduh95 @mcollina @jasnell @lpinca @mhdawson @jakecastelli