emit error events consistently in next tick#5251
Closed
thefourtheye wants to merge 1 commit intonodejs:masterfrom
Closed
emit error events consistently in next tick#5251thefourtheye wants to merge 1 commit intonodejs:masterfrom
error events consistently in next tick#5251thefourtheye wants to merge 1 commit intonodejs:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to callbacks,
errorevents also have to be emitted in thenextTick, so that they will be guaranteed to work asynchronously. This
patch makes sure all the
erroreventsmaintain the context and that would be useful more often)
process.nextTickI added major label as well, as this changes the behaviour of the existing system.
Also, this removes few TODOs left by @isaacs and @bnoordhuis