url: use ada::url_aggregator for parsing urls#47339
Merged
Trott merged 3 commits intonodejs:mainfrom Apr 5, 2023
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request:
adaand replacesada::urlwithada::url_aggregatorin correct placesThe release notes for Ada v2.0 can be found from https://www.yagiz.co/announcing-ada-url-parser-v2-0/
Added the
notable-changelabel due to removing the requirement forICUfor proper hostname parsing.Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1314/
cc @lemire @miguelteixeiraa