test: reduce flakiness of parallel/test-http-remove-header-stays-removed.js#46855
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Mar 18, 2023
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
test-http-remove-header-stays-removed.jsseems to be slightly flaky as seen in nodejs/reliability#508 and also reproducible locally by runningpython3 tools/test.py test/parallel/test-http-remove-header-stays-removed.js --repeat 1000Since the test checks that the socket is closed right after receiving the last chunk of data hence moved the checking for the same after the data has been received and slightly increased the timeout, the flakiness no longer reproduces
Refs: nodejs/reliability#508
Refs: #46333