Skip to content

querystring: improve parse() performance#4675

Closed
mscdex wants to merge 1 commit intonodejs:masterfrom
mscdex:querystring-parse-perf
Closed

querystring: improve parse() performance#4675
mscdex wants to merge 1 commit intonodejs:masterfrom
mscdex:querystring-parse-perf

Conversation

@mscdex
Copy link
Contributor

@mscdex mscdex commented Jan 13, 2016

These changes improve parse() performance from ~12-32% on all of the existing querystring benchmarks:

querystring/querystring-parse.js type=noencode n=1000000: ./node: 444400 ./node-prev: 369170 ... 20.38%
querystring/querystring-parse.js type=encodemany n=1000000: ./node: 383030 ./node-prev: 288910 . 32.58%
querystring/querystring-parse.js type=encodelast n=1000000: ./node: 392020 ./node-prev: 336360 . 16.55%
querystring/querystring-parse.js type=multivalue n=1000000: ./node: 269660 ./node-prev: 240230 . 12.25%

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

querystring Issues and PRs related to the built-in querystring module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants