Skip to content

test_runner: flatten TAP output when running using --test#46440

Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom
MoLow:flatten-tap-output
Feb 18, 2023
Merged

test_runner: flatten TAP output when running using --test#46440
nodejs-github-bot merged 2 commits intonodejs:mainfrom
MoLow:flatten-tap-output

Conversation

@MoLow
Copy link
Member

@MoLow MoLow commented Jan 31, 2023

Refs: #45833 (comment)
Fixes: #45833

this removes the reporting of a test file and reports its children's tests directly
A few notable things/edge cases:

  • if a test file does not have child tests (e.g an empty file, a file that does not output TAP) - we will include it in the top-level output
  • if a test file has child tests, and none of them failed - but the exit code was non-zero - we will include it in the top-level output. an example of this is a test with extraneous async activity

also diff of test_runner_output_cli.out is 10X more readable when diff is set to ignore whitespaces

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node --test does not show skipped tests in TAP result

7 participants