Skip to content

src: use named struct instead of typedef#43881

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
tniessen:src-crypto-named-struct-instead-of-typedef
Jul 18, 2022
Merged

src: use named struct instead of typedef#43881
nodejs-github-bot merged 1 commit intonodejs:mainfrom
tniessen:src-crypto-named-struct-instead-of-typedef

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Jul 18, 2022

There is no reason to use typedef with an unnamed struct here, and using a named struct is consistent with the rest of the codebase.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@aduh95 aduh95 aduh95 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

+1 more reviewer

@aymen94 aymen94 aymen94 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. fast-track PRs that do not need to wait for 72 hours to land. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@tniessen @nodejs-github-bot @panva @bnoordhuis @BridgeAR @aymen94 @aduh95 @RaisinTen @F3n67u