http2: close stream and session on frameError#42147
Merged
nodejs-github-bot merged 1 commit intonodejs:masterfrom Mar 2, 2022
Merged
http2: close stream and session on frameError#42147nodejs-github-bot merged 1 commit intonodejs:masterfrom
nodejs-github-bot merged 1 commit intonodejs:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address: #35133.
From the Http2Stream#frameError event documentation:
The master implementation wasn't closing the stream/session when a
frameErroroccurs. Also, it was calling theframeErrorevent with annghttp2internal error code.This PR translates the internal error code according to RFC 7540 and closes the connection when a
frameErroroccurs.