Skip to content

Capitalize Valgrind in docs#41986

Merged
nodejs-github-bot merged 12 commits intonodejs:masterfrom
mahmoud-moursy:capitalize_valgrind
Feb 15, 2022
Merged

Capitalize Valgrind in docs#41986
nodejs-github-bot merged 12 commits intonodejs:masterfrom
mahmoud-moursy:capitalize_valgrind

Conversation

@mahmoud-moursy
Copy link
Contributor

@mahmoud-moursy mahmoud-moursy commented Feb 15, 2022 •
edited
Loading

Change capitalizes Valgrind in the documentation, since Valgrind is a name.

See: PR #41966, and this PR in remark-present-lint-node.

This was split off from that PR as per @Trott's suggestion

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@Trott Trott Trott approved these changes

@benjamingr benjamingr benjamingr approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

@marsonya marsonya marsonya approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

+1 more reviewer

@Mesteery Mesteery Mesteery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 72 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@mahmoud-moursy @nodejs-github-bot @benjamingr @Trott @mcollina @tniessen @richardlau @marsonya @RaisinTen @Mesteery