Closed
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the next (and second to last since we already have
.from!) iterator helper from iterator helpers (ref: https://github.com/tc39/proposal-iterator-helpers#asindexedpairs )I am not basing this on reduce and I'll just deal with merge conflicts. I took Antoine's advice and wrote the tests in .mjs and it is indeed a lot neater although admittedly this is one of the simpler ones.
After this one (and
.findwhich I want to think a bit more about since we may want to support concurrency I want to focus on gathering feedback and iterating on the docs and on the tests (we still need a lot more coverage).cc @aduh95 @ronag @mcollina @Mesteery @vweevers @VoltrexMaster @nodejs/streams