Skip to content

stream: add flatMap to readable#41612

Closed
benjamingr wants to merge 1 commit intonodejs:masterfrom
benjamingr:stream-iterator-helper-flatMap
Closed

stream: add flatMap to readable#41612
benjamingr wants to merge 1 commit intonodejs:masterfrom
benjamingr:stream-iterator-helper-flatMap

Conversation

@benjamingr
Copy link
Member

@benjamingr benjamingr commented Jan 20, 2022

דארןלק<The normal caveat of this shouldn't landing until #41573 does and being a draft until then and to only look at the relevant commit :)

I am thinking about changing the toArray() behavior to not flatten a non-object-mode stream since I think things get tricky when flatMaping binary and non-binary streams together but I am honestly not sure and want feedback on much of the behaviours here.

Like the other iterator helpers PRs, this involves work co-authored by @ronag

cc @nodejs/streams

I am mostly interested in feedback about what the semantics should be and how flatMap works when flatMapping one stream mode and returning the other type from the mapper.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-failed An error occurred while landing this pull request using GitHub Actions. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants