Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am thinking about changing the
toArray()behavior to not flatten a non-object-mode stream since I think things get tricky whenflatMaping binary and non-binary streams together but I am honestly not sure and want feedback on much of the behaviours here.Like the other iterator helpers PRs, this involves work co-authored by @ronag
cc @nodejs/streams
I am mostly interested in feedback about what the semantics should be and how flatMap works when flatMapping one stream mode and returning the other type from the mapper.