Closed
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the next one and should only land after #41445 does (I'll rebase when it does).Marking as draft to not take CI resources until that one lands but I'd like reviews :)This adds the
toArraymethod from iterator helpers and addresses a common use case.My primary concern is that people don't over-use/abuse it though this is already pretty common with
toArrayand others on npm with many downloads.I don't remember if this was in the initial work with @ronag on map so I added a co-authored-by to be on the safe side though I assume this granularity of attribution doesn't really matter to either of us very much.
cc @ronag @nodejs/streams