fix,v8: make v8.writeHeapSnapshot throw if fopen/fclose fail#41373
Merged
nodejs-github-bot merged 1 commit intonodejs:masterfrom Jan 12, 2022
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #41346
Alternative to #41365, this PR makes
v8.writeHeapSnapshotthrow if the file could not be written, which can happen inside read-only directories (such as those from Docker containers).I was not able to make a readonly directory on Windows since I could still write new files to it (is it even possible on Windows?), so I created an empty readonly file instead and made the function attempt to write on it. I ran this function in both Node.js 16.13.1 and the test fails as intended.