esm: refactor esm tests out of test/message#41352
Merged
nodejs-github-bot merged 17 commits intonodejs:masterfrom Jan 6, 2022
Merged
esm: refactor esm tests out of test/message#41352nodejs-github-bot merged 17 commits intonodejs:masterfrom
nodejs-github-bot merged 17 commits intonodejs:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #40920 (comment).
This PR refactors the ESM tests that are currently in
test/messageto instead be with the rest of the ESM tests intest/es-module. This meant rewriting them from the.outstyle to instead spawn child processes. This has two benefits:tools/test.py -J es-modulenow does, in fact, run all the ESM tests..outfiles’ stack traces.In addition, there were some duplicated import assertion tests that I removed; and I slimmed down a few fixtures that we could do without.
cc @nodejs/modules @nodejs/loaders