Skip to content

esm: refactor esm tests out of test/message#41352

Merged
nodejs-github-bot merged 17 commits intonodejs:masterfrom
GeoffreyBooth:esm-out-tests
Jan 6, 2022
Merged

esm: refactor esm tests out of test/message#41352
nodejs-github-bot merged 17 commits intonodejs:masterfrom
GeoffreyBooth:esm-out-tests

Conversation

@GeoffreyBooth
Copy link
Member

Resolves #40920 (comment).

This PR refactors the ESM tests that are currently in test/message to instead be with the rest of the ESM tests in test/es-module. This meant rewriting them from the .out style to instead spawn child processes. This has two benefits:

  1. Running tools/test.py -J es-module now does, in fact, run all the ESM tests.
  2. Refactors to the ESM loader and associated files that change the call stack no longer require updating a bunch of .out files’ stack traces.

In addition, there were some duplicated import assertion tests that I removed; and I slimmed down a few fixtures that we could do without.

cc @nodejs/modules @nodejs/loaders

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders module Issues and PRs related to the module subsystem. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc: How to run just the .out tests?

6 participants