net: add new options to net.Socket and net.Server#41310
Merged
nodejs-github-bot merged 2 commits intonodejs:masterfrom Feb 22, 2022
Merged
net: add new options to net.Socket and net.Server#41310nodejs-github-bot merged 2 commits intonodejs:masterfrom
net.Socket and net.Server#41310nodejs-github-bot merged 2 commits intonodejs:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This PR adds the new following options to
net.Socket.connect:noDelay(boolean): If set totrue, callsuv_tcp_nodelayon the socket after connection. By default it is disabled.keepAlive(boolean) andkeepAliveDelay(number): If set totruecallsuv_tcp_nodelayon the socket after connection. By default it is disabled.This changes are needed as preliminary work on #34185 to avoid excessive JS to C++ bridging.
As I'm not a C++ expert, I encountered the following problems:
TCPWrap::AfterConnectwas tentative so some C++ expert should take a look. Moreover, what shall we do ifuv_tcp_connectsucceeds but any ofuv_tcp_nodelayoruv_tcp_keepalivefails? Shall we close the socket or let user handle it? Currently I don't do anything.Once this is initially reviewed, I will also add (either here or in a new PR) the analogous on inbound connections.