Skip to content

readline: add Promise-based API#37947

Closed
aduh95 wants to merge 4 commits intonodejs:masterfrom
aduh95:readline-promises
Closed

readline: add Promise-based API#37947
aduh95 wants to merge 4 commits intonodejs:masterfrom
aduh95:readline-promises

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 27, 2021 •
edited
Loading

This needs tests, but I'd like to get some feedback first to see if it's a direction we want to go at all.

  • provides a refactored version of readline.Interface written as ES6 class.
  • provides promesified version of callback based methods of readline.

semver-major because it exposes a new core module readline/promises.

Fixes: #37287

//cc @nodejs/readline

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb left review comments

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell left review comments

@benjamingr benjamingr benjamingr approved these changes

@ronag ronag ronag approved these changes

+1 more reviewer

@Mesteery Mesteery Mesteery left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. review wanted PRs that need reviews. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Promises version of ReadLine