Skip to content

http: onFinish will not be triggered again when finished#35845

Closed
rickyes wants to merge 5 commits intonodejs:masterfrom
rickyes:fix/http-outgoing-end
Closed

http: onFinish will not be triggered again when finished#35845
rickyes wants to merge 5 commits intonodejs:masterfrom
rickyes:fix/http-outgoing-end

Conversation

@rickyes
Copy link
Contributor

@rickyes rickyes commented Oct 28, 2020

When the .end() is called with the payload again after the end, directly return and pass the ERR_STREAM_WRITE_AFTER_END error to the callback and error event.

Fixes: #35833

/cc @ronag @kaizhu256

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v15.x regression - ERR_INTERNAL_ASSERTION - failed assert(socket._httpMessage === this);

7 participants