zlib: only apply drain listener if given callback#3534
Closed
MylesBorins wants to merge 3 commits intonodejs:masterfrom
MylesBorins:null-check-drain-listener
Closed
zlib: only apply drain listener if given callback#3534MylesBorins wants to merge 3 commits intonodejs:masterfrom MylesBorins:null-check-drain-listener
MylesBorins wants to merge 3 commits intonodejs:masterfrom
MylesBorins:null-check-drain-listener
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When stream.flush() is called without a callback, an empty listener is
being added. Since flush may be called multiple times to push SSE's
down to the client, multiple noop listeners are being added. This in
turn causes the memory leak detected message.
fixes #3529
This commit has been cherry picked from a pr on v0.x-archive
nodejs/node-v0.x-archive#25679