Skip to content

[v10.x] build: expose napi_build_version variable#35266

Closed
gabrielschulhof wants to merge 1 commit intonodejs:v10.x-stagingfrom
gabrielschulhof:backport-napi_build_version-to-v10.x
Closed

[v10.x] build: expose napi_build_version variable#35266
gabrielschulhof wants to merge 1 commit intonodejs:v10.x-stagingfrom
gabrielschulhof:backport-napi_build_version-to-v10.x

Conversation

@gabrielschulhof
Copy link
Contributor

Expose napi_build_version to allow node-gyp to make it
available for building native addons.

Fixes: nodejs/node-gyp#1745
Refs: nodejs/abi-stable-node#371
PR-URL: #27835
Reviewed-By: @bnoordhuis
Reviewed-By: @addaleax
Reviewed-By: @gabrielschulhof
Reviewed-By: @lpinca
Reviewed-By: @richardlau
Reviewed-By: @mhdawson

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. node-api Issues and PRs related to the Node-API. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants