readline: promote _getCursorPos to public api#30687
Closed
Js-Brecht wants to merge 5 commits intonodejs:masterfrom
Closed
readline: promote _getCursorPos to public api#30687Js-Brecht wants to merge 5 commits intonodejs:masterfrom
Js-Brecht wants to merge 5 commits intonodejs:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aliases Interface._getCursorPos to Interface.getCursorPos, for consumption as a public API.
If so desired, I can replace
_getCursorPosmethod calls withgetCursorPos, and create an alias the other way around. Doing it like this was just the simplest way to accomplish exposing_getCursorPos.refs: #30347
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes