src: reorganize process object creation, property implementation and events in C++ land#25397
Closed
joyeecheung wants to merge 7 commits intonodejs:masterfrom
Closed
src: reorganize process object creation, property implementation and events in C++ land#25397joyeecheung wants to merge 7 commits intonodejs:masterfrom
joyeecheung wants to merge 7 commits intonodejs:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src: move process object creation into node_process_object.cc
Changes
SetupProcessObjecttoCreateProessObjectwhich createsthe process object from scratch and return it to
Environment::Startto be stored in the Environment object.
src: declare process-related C++ methods in node_process.h
Instead of in node_internals.h. Also move process property
accessors that are not reused into node_process_object.cc
and make them static.
process: move C++ process events into node_process_events.cc
Move the C++
process.emitandprocess.emitWarningmethodsfrom
node.ccinto intonode_process_events.cc, andreuse the implementation in other places that need to do
process.emitin C++.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes