Skip to content

src: reorganize process object creation, property implementation and events in C++ land#25397

Closed
joyeecheung wants to merge 7 commits intonodejs:masterfrom
joyeecheung:move-process
Closed

src: reorganize process object creation, property implementation and events in C++ land#25397
joyeecheung wants to merge 7 commits intonodejs:masterfrom
joyeecheung:move-process

Conversation

@joyeecheung
Copy link
Member

src: move process object creation into node_process_object.cc

Changes SetupProcessObject to CreateProessObject which creates
the process object from scratch and return it to Environment::Start
to be stored in the Environment object.

src: declare process-related C++ methods in node_process.h

Instead of in node_internals.h. Also move process property
accessors that are not reused into node_process_object.cc
and make them static.

process: move C++ process events into node_process_events.cc

Move the C++ process.emit and process.emitWarning methods
from node.cc into into node_process_events.cc, and
reuse the implementation in other places that need to do
process.emit in C++.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants