fs: improve argument handling for ReadStream#19898
Closed
ryzokuken wants to merge 26 commits intonodejs:masterfrom
Closed
fs: improve argument handling for ReadStream#19898ryzokuken wants to merge 26 commits intonodejs:masterfrom
ryzokuken wants to merge 26 commits intonodejs:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve handling of erratic arguments in fs.ReadStream
Refs: #19732
For the uninitiated, a summary of what I'm planning to change:
undefinedInfinity)Infinity)NumberERR_INVALID_ARG_TYPEERR_INVALID_ARG_TYPENaNERR_INVALID_ARG_TYPEERR_OUT_OF_RANGENumbersERR_OUT_OF_RANGENumbersMath.roundERR_OUT_OF_RANGEERR_OUT_OF_RANGEChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passescc @addaleax @anliting @nodejs/fs