[x9.x backport] src: remove unused using declarations async_wrap#19253
Closed
danbev wants to merge 1 commit intonodejs:v9.xfrom
Closed
[x9.x backport] src: remove unused using declarations async_wrap#19253danbev wants to merge 1 commit intonodejs:v9.xfrom
danbev wants to merge 1 commit intonodejs:v9.xfrom
Conversation
PR-URL: nodejs#18893 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Contributor
Author
Contributor
Author
node-test-commit failure looks unrelated |
cjihrig
approved these changes
Mar 9, 2018
jasnell
approved these changes
Mar 9, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Mar 20, 2018
Backport-PR-URL: #19253 PR-URL: #18893 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Contributor
|
landed in 1ba1861 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #18893
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Minwoo Jung minwoo@nodesource.com
Reviewed-By: Yuta Hiroto hello@about-hiroppy.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
Reviewed-By: Gibson Fahnestock gibfahn@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes