Skip to content

net: do not inherit the no-half-open enforcer#18974

Closed
lpinca wants to merge 2 commits intonodejs:masterfrom
lpinca:avoid/inheriting-onend-listener
Closed

net: do not inherit the no-half-open enforcer#18974
lpinca wants to merge 2 commits intonodejs:masterfrom
lpinca:avoid/inheriting-onend-listener

Conversation

@lpinca
Copy link
Copy Markdown
Member

@lpinca lpinca commented Feb 24, 2018

Socket.prototype.destroySoon() is called as soon as UV_EOF is read
if the allowHalfOpen option is disabled. This already works as a
"no-half-open enforcer" so there is no need to inherit another from
stream.Duplex.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

net

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

net Issues and PRs related to the net subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants