test: Enable specifying flaky tests on fips#16329
Closed
komawar wants to merge 1 commit intonodejs:masterfrom
Closed
test: Enable specifying flaky tests on fips#16329komawar wants to merge 1 commit intonodejs:masterfrom
komawar wants to merge 1 commit intonodejs:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a way to mark a specified test as 'flaky' on fips compliant
systems.
Earlier, the
tools/test.pyscript supported only 'mode','system' and 'arch' for test environment specification. This limits the
ability to specify the behavior of tests and setting pre-determined
behavior of the same on other types of systems. As an example, the
feature request below indicates the need to specify certain tests as
'flaky' on fips compliant systems. It hints at future possibility of a
shared library, which in turn may need a specifier for running tests.
This commit introduces a new item in the
envdict, calledtypewhich defaults to
simpletype. It also adds an optional commandline argument
--type, which inputs strings. Current functionalityextends to setting
simpleorfipsfor thistypevariable.However, extending it to further uses is rather simple by adding "if"
conditions at appropriate places in the
tools/test.pyscript.Fixes: #14746
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)