Skip to content

deps: cherry-pick 1aead19 from upstream V8#15184

Closed
bnoordhuis wants to merge 1 commit intonodejs:masterfrom
bnoordhuis:thin-strings-postmortem
Closed

deps: cherry-pick 1aead19 from upstream V8#15184
bnoordhuis wants to merge 1 commit intonodejs:masterfrom
bnoordhuis:thin-strings-postmortem

Conversation

@bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Sep 4, 2017

Original commit message:

Add postmortem metadata for thin strings.

See: https://github.com/nodejs/llnode/issues/117
Change-Id: Icc2830c8e9096610df33ffdc2f89e74cb1b35662
Reviewed-on: https://chromium-review.googlesource.com/618986
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Ben Noordhuis <info@bnoordhuis.nl>
Cr-Commit-Position: refs/heads/master@{#47778}

Refs: nodejs/llnode#117
Refs: nodejs/llnode#121

cc @joyeecheung

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

post-mortem Issues and PRs related to the post-mortem diagnostics of Node.js. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@bnoordhuis @jasnell @MylesBorins @targos @cjihrig @joyeecheung @BridgeAR @nodejs-github-bot