https: disallow boolean types for key and cert options#14807
Closed
jimmycann wants to merge 4 commits intonodejs:masterfrom
Closed
https: disallow boolean types for key and cert options#14807jimmycann wants to merge 4 commits intonodejs:masterfrom
key and cert options#14807jimmycann wants to merge 4 commits intonodejs:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first PR on the Node repository, your feedback is greatly appreciated.
When using https.createServer, passing boolean values for
keyandcertproperties in the options object parameter doesn't throw an error an could lead to potential issues if they're accidentally passed.This PR aims to throw a reasonable error if a boolean was passed to either of those properties.
Fixes: #12802
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
https