Skip to content

https: disallow boolean types for key and cert options#14807

Closed
jimmycann wants to merge 4 commits intonodejs:masterfrom
jimmycann:issue/12802
Closed

https: disallow boolean types for key and cert options#14807
jimmycann wants to merge 4 commits intonodejs:masterfrom
jimmycann:issue/12802

Conversation

@jimmycann
Copy link
Contributor

This is my first PR on the Node repository, your feedback is greatly appreciated.

When using https.createServer, passing boolean values for key and cert properties in the options object parameter doesn't throw an error an could lead to potential issues if they're accidentally passed.

This PR aims to throw a reasonable error if a boolean was passed to either of those properties.

Fixes: #12802

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

https

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

https Issues or PRs related to the https subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants