Skip to content

lib/net: Convert to using internal/errors#14782

Closed
pmatzavin wants to merge 10 commits intonodejs:masterfrom
pmatzavin:lib_net_convert_err
Closed

lib/net: Convert to using internal/errors#14782
pmatzavin wants to merge 10 commits intonodejs:masterfrom
pmatzavin:lib_net_convert_err

Conversation

@pmatzavin
Copy link

@pmatzavin pmatzavin commented Aug 12, 2017

Covert lib/net.js over to using lib/internal/errors.js

Ref: #11273

I have not addressed the cases that use errnoException(),
for reasons described in GH-12926

  • Replace thrown errors in lib/net.js
    with errors from lib/internal/errors
  • Update tests according to the above modification
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

lib/net, doc

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

errors Issues and PRs related to JavaScript errors originated in Node.js core. net Issues and PRs related to the net subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.