zlib: fix node crashing on invalid options#13098
Closed
aqrln wants to merge 6 commits intonodejs:masterfrom
Closed
zlib: fix node crashing on invalid options#13098aqrln wants to merge 6 commits intonodejs:masterfrom
aqrln wants to merge 6 commits intonodejs:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the Node process crashing when constructors of classes of the
zlibmodule are given invalid options.windowBits, instead of crashing with an assertion.windowBitsandmemLeveloptions consistently with other ones and don't crash when non-numeric values are given.Fixes: #13082
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
zlib