docs: be specific about the unit of maxBuffer#8815
docs: be specific about the unit of maxBuffer#8815timruffles wants to merge 1 commit intonodejs:masterfrom
maxBuffer#8815Conversation
|
I'm in favor of specifying the units. Personally, I think it would be better if the existing sentence:
Was used, possibly with minor edits, as the description of the option. |
|
Hey @timruffles could you re-submit this PR to https://github.com/iojs/io.js? Someone could adopt it for you if you are not interested. |
|
Please wrap lines at 80 characters. Then, LGTM. |
998dbfe to
cb7cc1e
Compare
the maxBuffer option was not self-documenting, so document unit and its effect.
|
done |
|
@geek PTAL |
|
@timruffles looks good... interested in resubmitting after a merge with the current master? Master has changed since you first submitted and the patch doesn't apply nicely :) |
|
Already landed in nodejs/node. Going to go ahead and close this here. We can cherry pick the io.js commit back to v0.12 if necessary. Thanks for the PR! |
It's nice to be specific about units in docs.