Remove grunt webdriver task for pull requests#1089
Closed
eKoopmans wants to merge 1 commit intoniklasvh:masterfrom
Closed
Remove grunt webdriver task for pull requests#1089eKoopmans wants to merge 1 commit intoniklasvh:masterfrom
eKoopmans wants to merge 1 commit intoniklasvh:masterfrom
Conversation
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: Grunt webdriver task for pull requests
The
webdrivertask in the Grunt testing process doesn't work for external pull requests, and is causing all PRs to fail.Fix
The webdriver task is set up to connect to Sauce Labs, which hosts the Selenium cloud for browser testing. To connect to Sauce Labs,
tests/utils.jslooks for the environment variablesSAUCE_USERNAMEandSAUCE_ACCESS_KEY.Unfortunately, those variables are encrypted in .travis.yml (as they should be), which means that they are not available to pull requests from forks. Thus the test fails, because it never connects to Sauce Labs.
To prevent this guaranteed failure, I have disabled the
webdrivertask if it detects that it is being performed in a pull request, as recommended in the Travis documentation:Related issues/pull requests
#782, #941, #1084, #1085, #1086, #1087, #1088
(And really every open pull request, since none can currently pass with the current setup).