Add fallback for Codespace environment variables#60663
Open
R0Wi wants to merge 1 commit into
Open
Conversation
Signed-off-by: Robin Windey <ro.windey@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codespace.config.phpanymore #60662Summary
For some reason when using Github Codepaces, the environment variables are not set and threfore the host overwrite does not work properly.
Resolution notes
getenv()returns false under Apache because Apache is started via sudo service and never inherits the user shell's environment (which is populated bycodespaces.sh).getenv()returns empty (orfalse), the config now falls back to readingCODESPACE_NAMEfromenvironment-variables.json(a file Codespaces always maintains) and defaultsGITHUB_CODESPACES_PORT_FORWARDING_DOMAINto app.github.dev (the fixed GitHub Codespaces domain).Checklist
3. to review, feature component)stable32)AI (if applicable)