fix(files,systemtags): correct tag-folder breadcrumb, DAV root filtering, and nav label#60657
Open
deic-cloud wants to merge 3 commits into
Open
fix(files,systemtags): correct tag-folder breadcrumb, DAV root filtering, and nav label#60657deic-cloud wants to merge 3 commits into
deic-cloud wants to merge 3 commits into
Conversation
Signed-off-by: Worker Builder <worker-builder@nextcloud.com>
[stable34] 34.0.0 RC1
- BreadCrumbs: fall back to activeFolder.displayname while path store is
not yet populated (tag folder before REPORT completes)
- files store onUpdatedNode: skip nodes whose root is not the files DAV
root — systemtag folder nodes share the integer-ID namespace but live
under /systemtags and cannot be fetched via /files/{uid}; this prevents
spurious 404s when systemtags:node:updated fires
- systemtagsView: rename navigation entry 'Tags' → 'All tags' to match
the label shown in the left sidebar
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
deic-cloud
requested review from
come-nc,
nfebe,
provokateurin and
sorbaugh
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three related fixes for the systemtags/files integration:
BreadCrumbs.vue — Fall back to
activeFolder.displaynamewhile the path store is not yet populated (e.g. a tag folder before the REPORT response completes). Previously the breadcrumb showed a raw path segment instead of the tag name.files store
onUpdatedNode— Filter nodes to only those under the files DAV root before fetching updates. Systemtag folder nodes share the integer-ID namespace with regular files but live under/systemtags; attempting to re-fetch them via the/files/{uid}DAV client caused spurious 404s wheneversystemtags:node:updatedfired (e.g. when tag chips are rendered).systemtagsView.ts — Rename the navigation entry from
'Tags'to'All tags'to match the label shown in the left sidebar and avoid confusion with per-tag views.Test plan
🤖 Generated with Claude Code