Skip to content

Move OC host/port/protocol helpers to the bundle and deprecate them#15520

Merged
ChristophWurst merged 1 commit into
masterfrom
refactor/oc-host-port-protocol-bundle
May 14, 2019
Merged

Move OC host/port/protocol helpers to the bundle and deprecate them#15520
ChristophWurst merged 1 commit into
masterfrom
refactor/oc-host-port-protocol-bundle

Conversation

@ChristophWurst
Copy link
Copy Markdown
Member

They are pretty useless. If an app wants to mock that it can provide their own abstractions.

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels May 13, 2019
@ChristophWurst ChristophWurst added this to the Nextcloud 17 milestone May 13, 2019
@ChristophWurst ChristophWurst self-assigned this May 13, 2019
Copy link
Copy Markdown
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 13, 2019
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the refactor/oc-host-port-protocol-bundle branch from 933de7b to 9aeed85 Compare May 14, 2019 06:37
@ChristophWurst ChristophWurst merged commit b6c6be6 into master May 14, 2019
@ChristophWurst ChristophWurst deleted the refactor/oc-host-port-protocol-bundle branch May 14, 2019 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants