Skip to content

Move OC.dialogs to the main bundle#15294

Merged
skjnldsv merged 1 commit into
masterfrom
refactor/oc-dialogs-bundle
Apr 30, 2019
Merged

Move OC.dialogs to the main bundle#15294
skjnldsv merged 1 commit into
masterfrom
refactor/oc-dialogs-bundle

Conversation

@ChristophWurst
Copy link
Copy Markdown
Member

… and warn when the rarely used global OCDialog is accessed.

Comment thread core/src/globals.js
return newFunc
}

const setDeprecatedProp = (global, val, msg) =>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 30, 2019
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the refactor/oc-dialogs-bundle branch from 2fcec5a to 35d8e7a Compare April 30, 2019 09:11
@skjnldsv skjnldsv merged commit 265a284 into master Apr 30, 2019
@ChristophWurst ChristophWurst deleted the refactor/oc-dialogs-bundle branch April 30, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants