Disabling users in WebUI by MorrisJobke · Pull Request #1234 · nextcloud/server

MorrisJobke · 2016-09-01T14:55:30Z

Disabling users in WebUI #413 rebased on master - by @Faldon
I reviewed the layout and improved it a bit
I will continue reviewing it and read through all comments in Disabling users in WebUI #413 and try to fix them

MorrisJobke · 2016-09-01T14:57:07Z

It now looks like this:

Before it looked like this:

MorrisJobke · 2016-09-01T15:02:07Z

I tested this and it works quite well 👍 from me

@rullzer @nickvergessen @LukasReschke @Mar1u5 @nextcloud/designers Please review

Faldon · 2016-09-04T16:53:58Z

@MorrisJobke Sorry, was out of town for a few days. I'm glad someone more drone experienced does the fixes. ;-)

rullzer · 2016-09-09T05:48:48Z

SVGs need to be minimized
SVGs need proper viewBox

rullzer · 2016-09-09T06:02:58Z

 		if ($this->isAdmin) {
-
-			if($gid !== '') {
+			if($gid !== '' && $gid !== 'disabledUsers') {


This will explode if anybody ever creates a group disabledUsers

Then name it NextcloudDisabledUsers

Why not just another parameter $disabledUsers that defaults to false?

Ah yes ... makes sense then 🙈 It's early in the morning 😝

Well we have the same problem with the group "everyone"

rullzer · 2016-09-09T06:09:24Z

Rebased
Fixed the current unit tests
Add unit tests for disabled users

MorrisJobke · 2016-09-09T12:01:47Z

SVGs need proper viewBox

Why?

rullzer · 2016-09-10T18:59:57Z

@MorrisJobke because else firefox et all might desicde to do weird stuff again ;)

MorrisJobke · 2016-09-11T22:18:11Z

@MorrisJobke because else firefox et all might desicde to do weird stuff again ;)

But there is a viewbox ;)

rullzer · 2016-09-12T06:39:50Z

now there is ;)

MorrisJobke · 2016-09-14T13:09:55Z

@rullzer Unit tests are added.

This is ready for review - cc @LukasReschke @nickvergessen @rullzer

nickvergessen · 2016-09-14T13:56:46Z

 		if ($this->isAdmin) {
-
-			if($gid !== '') {
+			if($gid !== '' && $gid !== '_disabledUsers') {


Should we add a public constant for this?

I would say that this is something for a different PR, because then the "_everyone" group should also be handled.

rullzer · 2016-09-14T17:57:54Z

LGTM then!

MorrisJobke · 2016-09-17T21:23:53Z

@LukasReschke please review :)

Implemented visuals for enabling/disabling user from admin user list. Added the controller functions for enabling/disabling a user. Added the route for changing user status (enabled/disabled) and added an additional route handler in the user controller. Finished the visuals to reflect current user status and changed user status respectively. Changed the single icon for enabling/disabling a user into a menu where deletion and state toggling of a user is selectable. Added displaying of disabled user count. Improved style of user action menu. Added proper counting of disabled users. Removed visual indicator for disabled users. Moved pseudo-group detection for disabled users from frontend to the controller. Changed units for newly introduced css values from em to px. Removed unnecessary png and optimized svg with scour. Changed the userlist template to display the user action menu with correct width. Style fixes for better readability and coding style conformity. Changed the icons for enabling, disabling and deleting a user in the action menu.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Users page takes advantage of that Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

and fix a unit test Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

MorrisJobke · 2017-04-29T03:59:31Z

Rebased to resolve conflicts in test file

MorrisJobke · 2017-04-29T04:05:33Z

Tested and works 👍

MorrisJobke · 2017-04-29T04:36:43Z

Nearly 9 months after the rebase - sorry that it took so long, @Faldon

MorrisJobke added the 2. developing Work in progress label Sep 1, 2016

MorrisJobke self-assigned this Sep 1, 2016

MorrisJobke mentioned this pull request Sep 1, 2016

Disabling users in WebUI #413

Closed

MorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 1, 2016

MorrisJobke removed their assignment Sep 1, 2016

MorrisJobke added this to the Nextcloud 11.0 milestone Sep 1, 2016

MorrisJobke mentioned this pull request Sep 1, 2016

Ability to disable users #283

Closed

MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 1, 2016

MorrisJobke self-assigned this Sep 1, 2016

rullzer reviewed Sep 9, 2016
View reviewed changes

rullzer force-pushed the rebase-413-by-faldon branch from f929411 to 300d2d9 Compare September 9, 2016 06:08

MorrisJobke force-pushed the rebase-413-by-faldon branch from 66a4ce6 to 6024cce Compare September 14, 2016 12:31

MorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 14, 2016

MorrisJobke removed their assignment Sep 14, 2016

nickvergessen reviewed Sep 14, 2016
View reviewed changes

blizzz removed the 2. developing Work in progress label Apr 28, 2017

MariusBluem mentioned this pull request Apr 28, 2017

Move impersonate-button into dropdown with "disable" and "delete" user nextcloud/impersonate#4

Closed

Thomas Pulzer and others added 18 commits April 29, 2017 00:54

improve layout

0ab8501

Fix unit tests

84b4d44

optimize SVGs

d91b404

change group id to _disabledUsers

7be031a

adjust tests to have at least one disabled user

79d74a1

add unit tests for disable method

e521b67

add unit tests for enable method

7255037

check $user object before using it

74e5091

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

fix unit tests

a8457df

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

fix greyed out display name

74802ca

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Improve wording of error messages

2507e74

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

use proper return codes and handle failure cases

485d6d6

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

fix unit tests

4c37c38

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Use short array syntax

8f5f26c

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

UserManager can now count disabled users

668fe7d

Users page takes advantage of that Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

consolidate setEnabled method

99e97f1

and fix a unit test Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

align popovermenu next to … buttonthingy

c0e4fd0

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

MorrisJobke force-pushed the rebase-413-by-faldon branch from d7fa187 to c0e4fd0 Compare April 29, 2017 03:59

MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 29, 2017

MorrisJobke merged commit 854dfef into master Apr 29, 2017

MorrisJobke deleted the rebase-413-by-faldon branch April 29, 2017 04:35

MariusBluem mentioned this pull request Apr 29, 2017

User managenent polishing (Disable, ...) #4589

Closed

MorrisJobke mentioned this pull request May 9, 2017

Dropdown in personal settings broken. #4672

Closed

Uh oh!

Conversation

MorrisJobke commented Sep 1, 2016

Uh oh!

MorrisJobke commented Sep 1, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MorrisJobke commented Sep 1, 2016

Uh oh!

Faldon commented Sep 4, 2016

Uh oh!

rullzer commented Sep 9, 2016 • edited by MorrisJobke Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rullzer Sep 9, 2016

Choose a reason for hiding this comment

Uh oh!

MorrisJobke Sep 9, 2016

Choose a reason for hiding this comment

Uh oh!

rullzer Sep 9, 2016

Choose a reason for hiding this comment

Uh oh!

MorrisJobke Sep 9, 2016

Choose a reason for hiding this comment

Uh oh!

nickvergessen Sep 9, 2016

Choose a reason for hiding this comment

Uh oh!

rullzer commented Sep 9, 2016 • edited by MorrisJobke Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MorrisJobke commented Sep 9, 2016

Uh oh!

rullzer commented Sep 10, 2016

Uh oh!

MorrisJobke commented Sep 11, 2016

Uh oh!

rullzer commented Sep 12, 2016

Uh oh!

MorrisJobke commented Sep 14, 2016

Uh oh!

nickvergessen Sep 14, 2016

Choose a reason for hiding this comment

Uh oh!

MorrisJobke Sep 14, 2016

Choose a reason for hiding this comment

Uh oh!

rullzer commented Sep 14, 2016

Uh oh!

MorrisJobke commented Sep 17, 2016

Uh oh!

MorrisJobke commented Apr 29, 2017

Uh oh!

MorrisJobke commented Apr 29, 2017

Uh oh!

MorrisJobke commented Apr 29, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

MorrisJobke commented Sep 1, 2016 •

edited

Loading

rullzer commented Sep 9, 2016 •

edited by MorrisJobke

Loading

rullzer commented Sep 9, 2016 •

edited by MorrisJobke

Loading