Scope the cs-fixer and its dependencies#4739
Merged
Merged
Conversation
ChristophWurst
requested review from
GretaD,
StCyr,
kesselb,
miaulalala and
st3iny
miaulalala
approved these changes
Mar 11, 2021
Sometimes the dev dependencies of Mail cause a conflict with other apps or Nextcloud server. Most of the Symfony dev deps are pulled in via the php-cs-fixer, while that binary is actually independent and it doesn't need to load any of its classes into a Nextcloud process. Therefore we can use the composer bin plugin to move the bin into its own directory. `composer run cs:fix` works just like before. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
techdept/scoped-cs-fixer
branch
from
6a8a53d to
7ccb672
Compare
Member
Author
|
This needs an arguably ugly Psalm baseline update. The issue is that prior to nextcloud/server#25560 22 the event dispatcher relied on the Symfony components, Psalm knows that and complains that the event is not there (in isolation, when Nextcloud's autoloader isn't involved). This has been fixed, but as soon as we still target Nextcloud 20-21, the error might show up for any new event. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the dev dependencies of Mail cause a conflict with other apps
or Nextcloud server. Most of the Symfony dev deps are pulled in via the
php-cs-fixer, while that binary is actually independent and it doesn't
need to load any of its classes into a Nextcloud process. Therefore we
can use the composer bin plugin to move the bin into its own directory.
composer run cs:fixworks just like before.