test: fix quota test steps order

[saw-jan]

Description

The PR nextcloud/server#51750 has been merged and backported to other release branches (29, 30, 31). This change doesn't allow creating a folder after setting an insufficient quota. To create a folder at least 3584 bytes is required.
Therefore, rearranging the order of the test steps fixes the failing tests.

Related Issue or Workpackage

• WP#62654

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Updated CHANGELOG.md file

[github-actions]

PHP Code Coverage

Coverage after merging test/fix-quota-tests into master will be

63.60%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
integration_openproject/server/apps/integration_openproject/lib
Capabilities.php	0%	100%	0%	0%	24, 31–40
ServerVersionHelper.php	0%	100%	0%	0%	23–24, 27, 30
TokenEventFactory.php	100%	100%	100%	100%
integration_openproject/server/apps/integration_openproject/lib/AppInfo
Application.php	7.41%	100%	25%	6%	100, 102–105, 107, 109, 111, 115–118, 120–131, 133, 136, 140, 144–146, 73–75, 78–82, 84–89, 91–92, 95
integration_openproject/server/apps/integration_openproject/lib/BackgroundJob
RemoveExpiredDirectUploadTokens.php	0%	100%	0%	0%	28, 30–32, 41–42
integration_openproject/server/apps/integration_openproject/lib/Controller
ConfigController.php	75.45%	100%	66.67%	75.82%	138, 179–180, 182, 184–186, 188–191, 194–195, 197, 223, 233, 237–239, 479–481, 483–485, 534, 622–625, 627–628, 631, 639–643, 654, 668–671, 679, 683–686, 722, 725–740, 757–762, 764–765, 767–769, 772, 774–790, 804–807, 809–813
DirectDownloadController.php	0%	100%	0%	0%	33–35, 50–52, 54–61
DirectUploadController.php	70.83%	100%	100%	70%	124–126, 169–171, 182, 186–189, 191, 201, 208, 224–226, 228–229, 232–237, 240, 242, 250–252, 258–260, 268–270, 285–287, 306, 311, 317
FilesController.php	72.95%	100%	83.33%	72.41%	178–179, 241, 246–249, 251, 253–266, 269–270, 272–273, 277–280, 283, 289
OpenProjectAPIController.php	81.19%	100%	82.35%	81.08%	116, 155, 202–204, 207–214, 216–220, 222, 241, 266, 331, 381, 401, 448, 473–475, 478–482, 484, 75
OpenProjectController.php	96.45%	100%	80%	96.95%	241–245
integration_openproject/server/apps/integration_openproject/lib/Dashboard
OpenProjectWidget.php	0%	100%	0%	0%	101, 108–109, 111–116, 118–122, 126–128, 131–142, 61–66, 73, 80, 87, 94
integration_openproject/server/apps/integration_openproject/lib/Exception
OpenprojectAvatarErrorException.php	100%	100%	100%	100%
OpenprojectErrorException.php	100%	100%	100%	100%
OpenprojectFileNotUploadedException.php	100%	100%	100%	100%
OpenprojectGroupfolderSetupConflictException.php	100%	100%	100%	100%
OpenprojectResponseException.php	100%	100%	100%	100%
OpenprojectUnauthorizedUserException.php	0%	100%	0%	0%	21
integration_openproject/server/apps/integration_openproject/lib/Listener
BeforeGroupDeletedListener.php	0%	100%	0%	0%	30, 38–39, 42–45, 47
BeforeNodeInsideOpenProjectGroupfilderChangedListener.php	0%	100%	0%	0%	46–48, 52–55, 57, 59, 62–63, 65, 67–70, 72–75, 77–79
BeforeUserDeletedListener.php	0%	100%	0%	0%	30, 37–38, 40–43, 45
LoadAdditionalScriptsListener.php	0%	100%	0%	0%	37–38, 46–47, 49, 51–52, 54–56, 58
LoadSidebarScript.php	0%	100%	0%	0%	100, 102–103, 105–106, 108, 110–111, 113, 115, 117–124, 128, 131–136, 70–88, 97–98
OpenProjectReferenceListener.php	0%	100%	0%	0%	44–46, 53–54, 56, 58–59, 61–73
TermsOfServiceEventListener.php	0%	100%	0%	0%	41–42, 47–48, 50–51, 53–55, 58–62
UserChangedListener.php	0%	100%	0%	0%	34, 41–42, 45–50, 53
integration_openproject/server/apps/integration_openproject/lib/Migration
Version2001Date20221213083550.php	0%	100%	0%	0%	30, 40–48, 50–58, 60–62, 64
Version2310Date20230116153411.php	0%	100%	0%	0%	29, 32–35, 37–62, 64–65, 67
Version2400Date20230504144300.php	0%	100%	0%	0%	30, 40–43
Version2640Date20240628114301.php	0%	100%	0%	0%	35, 47–49, 52–53, 56
integration_openproject/server/apps/integration_openproject/lib/Reference
WorkPackageReferenceProvider.php	51.67%	100%	25%	58.33%	100–101, 104, 108, 142, 150–151, 159, 37, 44, 51, 58–60, 87, 93–96, 99
integration_openproject/server/apps/integration_openproject/lib/Search
OpenProjectSearchProvider.php	0%	100%	0%	0%	100–103, 105–108, 110–113, 117–118, 120–121, 124–133, 135–139, 52–55, 62, 69, 77, 79, 82, 89–90, 93–97, 99
OpenProjectSearchResultEntry.php	100%	100%	100%	100%
integration_openproject/server/apps/integration_openproject/lib/Service
DatabaseService.php	42.31%	100%	60%	40.43%	108–112, 114, 63–76, 78–85
DirectDownloadService.php	88.46%	100%	100%	87.50%	62–63, 65
DirectUploadService.php	42.86%	100%	66.67%	40%	101, 62–65, 67–75, 95
OauthService.php	28%	100%	40%	26.67%	100–105, 116–123,

[individual-it]

what about to set the quota to 3584+9 bytes?
Because now we don't know why the tests will react as expected. Because the folder already uses 3584 byte and that is > 9 or because we are uploading 10 bytes?

[saw-jan]

what about to set the quota to 3584+9 bytes? Because now we don't know why the tests will react as expected. Because the folder already uses 3584 byte and that is > 9 or because we are uploading 10 bytes?

this will not work. 3584 is required to create a folder but after creating a folder, all 3584 bytes will be an available and uploading file with 3584 bytes will work. In the tests we are just trying to upload few bytes.

[nabim777]

LGTM 👍

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)