Skip to content

fix(teams): circular Talk previews, border-radius-small for Files previews#5359

Open
jancborchardt wants to merge 1 commit into
mainfrom
fix/noid/teams-talk-circular-previews
Open

fix(teams): circular Talk previews, border-radius-small for Files previews#5359
jancborchardt wants to merge 1 commit into
mainfrom
fix/noid/teams-talk-circular-previews

Conversation

@jancborchardt
Copy link
Copy Markdown
Member

@jancborchardt jancborchardt commented May 27, 2026

Fixes the previews in Teams not looking correct. Together with nextcloud/circles#2494

Previews in Teams are currently square.
Previews for Files should have border-radius-small. The previews in "Talk conversations" should be circular.

Before After
Screenshot From 2026-05-27 14-02-23 Screenshot From 2026-05-27 13-56-28

Summary

  • Adds a provider-based CSS class (circle-details-section--{providerId}) to each resource section so styles can be scoped by provider
  • Talk conversation images get border-radius-pill (circular)
  • Files image previews get border-radius-small (slightly rounded corners)

Test plan

  • Open Contacts, navigate to a Team/Circle that has both shared Talk conversations and shared files
  • Confirm Talk conversation avatars are circular
  • Confirm Files image previews have small rounded corners

🤖 Generated with Claude Code

@jancborchardt jancborchardt self-assigned this May 27, 2026
@jancborchardt jancborchardt added bug Something isn't working 3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix. labels May 27, 2026
@jancborchardt jancborchardt added the feature: teams ex circles label May 27, 2026
@jancborchardt jancborchardt moved this to 🏗️ At engineering in 🖍 Design team May 27, 2026
@hamza221 hamza221 requested a review from cristianscheid May 27, 2026 12:23
@hamza221
Copy link
Copy Markdown
Contributor

@cristianscheid until which version should this be backported ?

@hamza221
Copy link
Copy Markdown
Contributor

/backport to stable8.6

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@cristianscheid
Copy link
Copy Markdown
Member

cristianscheid commented May 27, 2026

@cristianscheid until which version should this be backported ?

Hey @hamza221, just left a comment on circle's PR. I don't think changes on circle's repo are needed for this fix.

Regarding backporting, not sure how backporting works for contacts, but since currently NC supported versions are 33 and 32, the matching version of contacts for 32 seems to be v8.3.12, so maybe until v8.3.12?

Looking at https://github.com/nextcloud/contacts/blob/v8.3.12/src/components/CircleDetails.vue#L171, providerId variable used on this PR was already available so I think it should not break.

Copy link
Copy Markdown
Member

@cristianscheid cristianscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tested and worked as expected.

Only thing is that there's a NPM lint error to be solved: ':class' should be on a new line. On this section:

<div v-for="(group, providerId) in groupedResources" :key="providerId" class="circle-details-section" :class="`circle-details-section--${providerId}`">

@hamza221
Copy link
Copy Markdown
Contributor

hamza221 commented May 28, 2026

Looks good to me, tested and worked as expected.

Only thing is that there's a NPM lint error to be solved: ':class' should be on a new line. On this section:

<div v-for="(group, providerId) in groupedResources" :key="providerId" class="circle-details-section" :class="`circle-details-section--${providerId}`">

@jancborchardt npm run lint:fix then amend to the commit and force push should fix it

…views

- Add provider-based class (`circle-details-section--{providerId}`) to resource sections so styling can be scoped per provider
- Apply `border-radius-pill` to Talk conversation images (circular)
- Apply `border-radius-small` to Files image previews

AI-assisted: Claude Code (Sonnet 4.6)
Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
@jancborchardt jancborchardt force-pushed the fix/noid/teams-talk-circular-previews branch from 493d9b7 to db1ea52 Compare May 28, 2026 13:18
Copy link
Copy Markdown
Member Author

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hamza221 @cristianscheid thanks, fixed! (And rebased as well)

@hamza221
Copy link
Copy Markdown
Contributor

/backport to stable8.3

@hamza221 hamza221 enabled auto-merge May 28, 2026 13:25
@hamza221 hamza221 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish backport-request bug Something isn't working feature: teams ex circles papercut Annoying recurring issue with possibly simple fix.

Projects

Status: 🏗️ At engineering

Development

Successfully merging this pull request may close these issues.

3 participants