fix(teams): circular Talk previews, border-radius-small for Files previews#5359
fix(teams): circular Talk previews, border-radius-small for Files previews#5359jancborchardt wants to merge 1 commit into
Conversation
|
@cristianscheid until which version should this be backported ? |
|
/backport to stable8.6 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Hey @hamza221, just left a comment on circle's PR. I don't think changes on circle's repo are needed for this fix. Regarding backporting, not sure how backporting works for contacts, but since currently NC supported versions are 33 and 32, the matching version of contacts for 32 seems to be v8.3.12, so maybe until v8.3.12? Looking at https://github.com/nextcloud/contacts/blob/v8.3.12/src/components/CircleDetails.vue#L171, |
There was a problem hiding this comment.
Looks good to me, tested and worked as expected.
Only thing is that there's a NPM lint error to be solved: ':class' should be on a new line. On this section:
<div v-for="(group, providerId) in groupedResources" :key="providerId" class="circle-details-section" :class="`circle-details-section--${providerId}`">
@jancborchardt npm run lint:fix then amend to the commit and force push should fix it |
…views
- Add provider-based class (`circle-details-section--{providerId}`) to resource sections so styling can be scoped per provider
- Apply `border-radius-pill` to Talk conversation images (circular)
- Apply `border-radius-small` to Files image previews
AI-assisted: Claude Code (Sonnet 4.6)
Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
493d9b7 to
db1ea52
Compare
jancborchardt
left a comment
There was a problem hiding this comment.
@hamza221 @cristianscheid thanks, fixed! (And rebased as well)
|
/backport to stable8.3 |
Fixes the previews in Teams not looking correct. Together with nextcloud/circles#2494
Previews in Teams are currently square.
Previews for Files should have border-radius-small. The previews in "Talk conversations" should be circular.
Summary
circle-details-section--{providerId}) to each resource section so styles can be scoped by providerborder-radius-pill(circular)border-radius-small(slightly rounded corners)Test plan
🤖 Generated with Claude Code