Skip to content

Enhance Install Script with Version Check and Force Install Option#2575

Merged
mergify[bot] merged 3 commits into
nektos:masterfrom
james-crowley:master
Dec 25, 2024
Merged

Enhance Install Script with Version Check and Force Install Option#2575
mergify[bot] merged 3 commits into
nektos:masterfrom
james-crowley:master

Conversation

@james-crowley

Copy link
Copy Markdown
Contributor

This PR introduces improvements to the Act install script by adding logic to check if Act is already installed. If the installed version matches the requested tag, the script will skip the installation process. This enhancement is particularly useful in CI environments where Act might already be preinstalled, reducing redundant downloads and saving bandwidth.

Key Changes:

  • Version Check Logic: The script now checks if Act is already installed and whether its version matches the requested tag. If a match is found, the installation is skipped.

  • Force Install Flag -f: A new CLI flag -f has been added to bypass the version check. This ensures flexibility when users explicitly want to reinstall or downgrade Act.

  • Upgrade & Downgrade: The script only skips installation if the installed version matches the requested tag. It doesn’t prevent downgrades or upgrades to different versions, offering control to the end user.

@james-crowley james-crowley requested a review from a team as a code owner December 16, 2024 16:30
@mergify

mergify Bot commented Dec 24, 2024

Copy link
Copy Markdown
Contributor

@james-crowley this pull request has failed checks 🛠

@mergify mergify Bot added the needs-work Extra attention is needed label Dec 24, 2024
@codecov

codecov Bot commented Dec 24, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.75%. Comparing base (5a80a04) to head (d55c6e4).
Report is 138 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2575      +/-   ##
==========================================
+ Coverage   61.56%   68.75%   +7.19%     
==========================================
  Files          53       71      +18     
  Lines        9002    10918    +1916     
==========================================
+ Hits         5542     7507    +1965     
+ Misses       3020     2848     -172     
- Partials      440      563     +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify Bot removed the needs-work Extra attention is needed label Dec 24, 2024
@mergify mergify Bot merged commit fe017a1 into nektos:master Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants