Skip to content

[popper] Persist positioning styles when popperOptions changes reference#48121

Merged
mj12albert merged 2 commits into
mui:masterfrom
mj12albert:fix/reapply-popper-positioning-styles
Apr 16, 2026
Merged

[popper] Persist positioning styles when popperOptions changes reference#48121
mj12albert merged 2 commits into
mui:masterfrom
mj12albert:fix/reapply-popper-positioning-styles

Conversation

@mj12albert

@mj12albert mj12albert commented Mar 28, 2026

Copy link
Copy Markdown
Member

Root cause for mui/mui-x#21839

Fixes #33413
Fixes #48268

popper.destroy removes all inline positioning styles. When the effect here re-runs (options obj changed reference), the popper is destroyed and recreated where there is a brief moment where if a child component focuses an element (like the pickers calendar btn) it could cause unwanted scrolling

@mj12albert mj12albert added type: bug It doesn't behave as expected. component: Popper The React component. See <Popup> for the latest version. labels Mar 28, 2026
@mui-bot

mui-bot commented Mar 28, 2026

Copy link
Copy Markdown

Netlify deploy preview

https://deploy-preview-48121--material-ui.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/material 🔺+141B(+0.03%) 🔺+69B(+0.05%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against a962246

@mj12albert mj12albert force-pushed the fix/reapply-popper-positioning-styles branch from a962246 to 3104607 Compare April 15, 2026 14:17
@code-infra-dashboard

code-infra-dashboard Bot commented Apr 15, 2026

Copy link
Copy Markdown

Bundle size

Bundle Parsed size Gzip size
@mui/material 🔺+141B(+0.03%) 🔺+59B(+0.04%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/private-theming 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Deploy preview

https://deploy-preview-48121--material-ui.netlify.app/


Check out the code infra dashboard for more information about this PR.

@mj12albert mj12albert enabled auto-merge (squash) April 16, 2026 11:13
@mj12albert mj12albert added v7.x needs cherry-pick The PR should be cherry-picked to master after merge. labels Apr 16, 2026
@mj12albert mj12albert merged commit 88c4b0f into mui:master Apr 16, 2026
21 checks passed
@github-actions

Copy link
Copy Markdown

Cherry-pick PRs will be created targeting branches: v7.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: Popper The React component. See <Popup> for the latest version. needs cherry-pick The PR should be cherry-picked to master after merge. type: bug It doesn't behave as expected. v7.x

Projects

None yet

3 participants