[icons] Remove legacy *Outline icons#48116
Merged
mj12albert merged 3 commits intoApr 2, 2026
Merged
Conversation
Netlify deploy previewBundle size report
|
18238f8 to
fb438a6
Compare
fb438a6 to
92a2728
Compare
silviuaavram
approved these changes
Mar 30, 2026
Member
Author
|
@siriwatknp would you mind double-checking this, I don't think I've really touched the icons package before 🙏 |
siriwatknp
approved these changes
Apr 2, 2026
siriwatknp
left a comment
Member
There was a problem hiding this comment.
LGTM — all 23 legacy *Outline icon removals are clean, internal usages migrated, guard tests added, and migration docs are clear. No remaining references in the codebase.
cursor Bot
pushed a commit
to opencost/opencost-ui
that referenced
this pull request
May 27, 2026
Bumps the MUI v9 stack together so peer dependencies line up: - @mui/material 7.3.9 -> 9.0.1 - @mui/icons-material 7.3.9 -> 9.0.1 - @mui/x-date-pickers 8.27.2 -> 9.3.0 (8.x peer-pins @mui/material@^7) Replaces dependabot PR #245, which only bumped @mui/material and therefore failed npm install with peer-dep conflicts against @mui/icons-material@7.3.9 (and would have hit @mui/x-date-pickers@8 too). ### v9 breaking change handled The v9.0.0-beta.1 release removed the legacy `*Outline` icon aliases (see mui/material-ui#48116). All call sites that imported `DeleteOutline` were migrated to `DeleteOutlined`: - app/routes/dashboard-list.tsx - app/components/report-list-table.tsx - app/components/report-builder-side-panel.tsx (3 call sites) The `*Outlined` variants are the canonical Material Symbols name and have been available since v5; the legacy `*Outline` aliases are now gone. ### Notes - No Grid `direction='column'/'column-reverse'` usages exist in the codebase, so the v9.0.0-beta.1 Grid change does not apply. - The only ListItemIcon with a hardcoded minWidth (Nav/NavItem.jsx) uses sx overrides, so the v9 theme-spacing default does not affect it. - @mui/styles@^6.5.0 has no peer dep on @mui/material and continues to install cleanly alongside v9. - date-fns@^4.1.0 is supported by @mui/x-date-pickers@^9.3.0. ### Validation - `npm install` succeeds; `found 0 vulnerabilities`. - `npm run build` (new UI) passes. - `npm run build:legacy` passes. - `npx tsc --noEmit` shows no new errors over main (pre-existing errors in app/routes/legacy/external-costs.tsx are unchanged). Signed-off-by: cursor-agent[bot] <cursor-agent[bot]@users.noreply.github.com> Co-authored-by: Alex Meijer <ameijer@users.noreply.github.com> Signed-off-by: Cursor Agent <cursoragent@cursor.com>
cursor Bot
pushed a commit
to opencost/opencost-ui
that referenced
this pull request
Jun 2, 2026
Bumps the MUI v9 stack together so peer dependencies line up: - @mui/material 7.3.9 -> 9.0.1 - @mui/icons-material 7.3.9 -> 9.0.1 - @mui/x-date-pickers 8.27.2 -> 9.3.0 (8.x peer-pins @mui/material@^7) Replaces dependabot PR #245, which only bumped @mui/material and therefore failed npm install with peer-dep conflicts against @mui/icons-material@7.3.9 (and would have hit @mui/x-date-pickers@8 too). Rebased on top of recently-merged main (which includes #259/#260/#261). ### v9 breaking change handled The v9.0.0-beta.1 release removed the legacy `*Outline` icon aliases (see mui/material-ui#48116). All call sites that imported `DeleteOutline` were migrated to `DeleteOutlined`: - app/routes/dashboard-list.tsx - app/components/report-list-table.tsx - app/components/report-builder-side-panel.tsx (3 call sites) The `*Outlined` variants are the canonical Material Symbols name and have been available since v5; the legacy `*Outline` aliases are now gone. ### Notes - No Grid `direction='column'/'column-reverse'` usages exist in the codebase, so the v9.0.0-beta.1 Grid change does not apply. - The only ListItemIcon with a hardcoded minWidth (Nav/NavItem.jsx) uses sx overrides, so the v9 theme-spacing default does not affect it. - @mui/styles@^6.5.0 has no peer dep on @mui/material and continues to install cleanly alongside v9. - date-fns@^4.1.0 is supported by @mui/x-date-pickers@^9.3.0. ### Validation - `npm install` succeeds; `found 0 vulnerabilities`. - `npm run build` (new UI) passes. - `npm run build:legacy` passes. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Alex Meijer <ameijer@users.noreply.github.com>
nicolasmattelaer
pushed a commit
to nicolasmattelaer/opencost-ui
that referenced
this pull request
Jun 11, 2026
Bumps the MUI v9 stack together so peer dependencies line up: - @mui/material 7.3.9 -> 9.0.1 - @mui/icons-material 7.3.9 -> 9.0.1 - @mui/x-date-pickers 8.27.2 -> 9.3.0 (8.x peer-pins @mui/material@^7) Replaces dependabot PR opencost#245, which only bumped @mui/material and therefore failed npm install with peer-dep conflicts against @mui/icons-material@7.3.9 (and would have hit @mui/x-date-pickers@8 too). Rebased on top of recently-merged main (which includes opencost#259/opencost#260/opencost#261). ### v9 breaking change handled The v9.0.0-beta.1 release removed the legacy `*Outline` icon aliases (see mui/material-ui#48116). All call sites that imported `DeleteOutline` were migrated to `DeleteOutlined`: - app/routes/dashboard-list.tsx - app/components/report-list-table.tsx - app/components/report-builder-side-panel.tsx (3 call sites) The `*Outlined` variants are the canonical Material Symbols name and have been available since v5; the legacy `*Outline` aliases are now gone. ### Notes - No Grid `direction='column'/'column-reverse'` usages exist in the codebase, so the v9.0.0-beta.1 Grid change does not apply. - The only ListItemIcon with a hardcoded minWidth (Nav/NavItem.jsx) uses sx overrides, so the v9 theme-spacing default does not affect it. - @mui/styles@^6.5.0 has no peer dep on @mui/material and continues to install cleanly alongside v9. - date-fns@^4.1.0 is supported by @mui/x-date-pickers@^9.3.0. ### Validation - `npm install` succeeds; `found 0 vulnerabilities`. - `npm run build` (new UI) passes. - `npm run build:legacy` passes. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Alex Meijer <ameijer@users.noreply.github.com> Signed-off-by: nmattela <nicolas.bruno.mattelaer@vub.be>
nicolasmattelaer
pushed a commit
to nicolasmattelaer/opencost-ui
that referenced
this pull request
Jun 11, 2026
Bumps the MUI v9 stack together so peer dependencies line up: - @mui/material 7.3.9 -> 9.0.1 - @mui/icons-material 7.3.9 -> 9.0.1 - @mui/x-date-pickers 8.27.2 -> 9.3.0 (8.x peer-pins @mui/material@^7) Replaces dependabot PR opencost#245, which only bumped @mui/material and therefore failed npm install with peer-dep conflicts against @mui/icons-material@7.3.9 (and would have hit @mui/x-date-pickers@8 too). Rebased on top of recently-merged main (which includes opencost#259/opencost#260/opencost#261). ### v9 breaking change handled The v9.0.0-beta.1 release removed the legacy `*Outline` icon aliases (see mui/material-ui#48116). All call sites that imported `DeleteOutline` were migrated to `DeleteOutlined`: - app/routes/dashboard-list.tsx - app/components/report-list-table.tsx - app/components/report-builder-side-panel.tsx (3 call sites) The `*Outlined` variants are the canonical Material Symbols name and have been available since v5; the legacy `*Outline` aliases are now gone. ### Notes - No Grid `direction='column'/'column-reverse'` usages exist in the codebase, so the v9.0.0-beta.1 Grid change does not apply. - The only ListItemIcon with a hardcoded minWidth (Nav/NavItem.jsx) uses sx overrides, so the v9 theme-spacing default does not affect it. - @mui/styles@^6.5.0 has no peer dep on @mui/material and continues to install cleanly alongside v9. - date-fns@^4.1.0 is supported by @mui/x-date-pickers@^9.3.0. ### Validation - `npm install` succeeds; `found 0 vulnerabilities`. - `npm run build` (new UI) passes. - `npm run build:legacy` passes. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Alex Meijer <ameijer@users.noreply.github.com> Signed-off-by: nmattela <nicolas.bruno.mattelaer@vub.be>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47941