[inputs] Remove deprecated props & classes#48071
Merged
Merged
Conversation
mj12albert
added
breaking change
mj12albert
changed the title
Netlify deploy previewBundle size report
|
github-actions
Bot
added
the
PR: out-of-date
mj12albert
force-pushed
the
chore/input-deprecations
branch
from
279b44f to
03a43d0
Compare
github-actions
Bot
removed
the
PR: out-of-date
mj12albert
force-pushed
the
chore/input-deprecations
branch
from
03a43d0 to
a16ea77
Compare
mj12albert
force-pushed
the
chore/input-deprecations
branch
from
a16ea77 to
71ce52e
Compare
mj12albert
requested review from
silviuaavram and
siriwatknp
and removed request for
siriwatknp
siriwatknp
reviewed
Mar 24, 2026
Comment on lines
-57
to
-61
| it('should respects the componentsProps if passed', () => { | ||
| render(<FilledInput componentsProps={{ root: { 'data-test': 'test' } }} />); | ||
| expect(document.querySelector('[data-test=test]')).not.to.equal(null); | ||
| }); | ||
|
|
Member
There was a problem hiding this comment.
better convert this to slotProps than removing test?
siriwatknp
reviewed
Mar 24, 2026
silviuaavram
approved these changes
Mar 24, 2026
silviuaavram
left a comment
silviuaavram
left a comment
Member
There was a problem hiding this comment.
some test related comments
Comment on lines
-38
to
-42
| it('should respects the componentsProps if passed', () => { | ||
| render(<Input componentsProps={{ root: { 'data-test': 'test' } }} />); | ||
| expect(document.querySelector('[data-test=test]')).not.to.equal(null); | ||
| }); | ||
|
|
Member
There was a problem hiding this comment.
same here, convert test to slotProps equivalent
| </FormControl>, | ||
| ); | ||
| expect(container.querySelector('input')).to.have.class(classes.inputSizeSmall); | ||
| expect(screen.getByTestId('root')).to.have.class(classes.sizeSmall); |
Member
There was a problem hiding this comment.
should we also check input has class input? when migrating these, I usually check for the equivalents, and in this case, the equivalent also involves input class.
| const { container, setProps } = render(<InputBaseInFormWithMargin />); | ||
| expect(container.querySelector('input')).not.to.have.class(classes.inputSizeSmall); | ||
| const { setProps } = render(<InputBaseInFormWithMargin />); | ||
| expect(screen.getByTestId('root')).not.to.have.class(classes.sizeSmall); |
Member
There was a problem hiding this comment.
same here, check root small and input input
| expect(container.querySelector('input')).to.have.class(classes.inputSizeSmall); | ||
| }); | ||
|
|
||
| it('has an inputHiddenLabel class to further reduce margin', () => { |
Member
There was a problem hiding this comment.
maybe convert this test instead of removing it? check input + hiddenLabel
| expect(document.querySelector('.error')).not.to.equal(null); | ||
| }); | ||
|
|
||
| it('should respects the componentsProps if passed', () => { |
| />, | ||
| ); | ||
|
|
||
| expect(screen.getByTestId('mui-input-base-root')).to.have.class(inputBaseClasses.multiline); |
Member
There was a problem hiding this comment.
let's also check the input has class input
Member
Author
|
Added back all the tests dropped by Claude code 🤡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #47987